[SYCL][CL] Fix ownership of native handle in sycl::make_queue #18309
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kbenzie
force-pushed
the
benie/ur-cl-queue-interop-ownership
branch
from
52c1534 to
4ceb427
Compare
kbenzie
force-pushed
the
benie/ur-cl-queue-interop-ownership
branch
from
4ceb427 to
5059c31
Compare
kbenzie
force-pushed
the
benie/ur-cl-queue-interop-ownership
branch
from
5059c31 to
a2716e3
Compare
slawekptak
approved these changes
May 14, 2025
|
Failures being tracked in #18463 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Level Zero is the only backend which has any explicit ownership transfer controls when creating SYCL objects from native handles.
The CUDA and HIP backends already had the default to not transferring ownership of native handles.
Up until this patch the OpenCL backend was transferring ownership when creating with a native handle, when combined with the changes to the OpenCL adapter in #17572 this caused crashes in existing workloads which expect to manage ownership of the OpenCL native handles.
Fixes URT-905.